fix(AIP-203): disallow field_behavior in oneof #1181
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow the use of
google.api.field_beahvior
on fields in aoneof
. Even theimmutable
,output_only
, etc. would be redundant and/or confusing if applied to every field (consistently or otherwise). Instead we should explore defining agoogle.api.oneof_behavior
annotation to mimicfield_behavior
but for the entire group of oneof fields. That is a separate issue though.Fixes #1156