feat(AIP-202): add enriched Field descriptor AIP #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
requested review from
jskeet and
andrei-scripniciuc
and removed request for
loudej and
alin04
|
cc @slevenick @dizcology @ibelle @amanda-tarafa as an FYI |
loudej
previously requested changes
Sep 15, 2023
Co-authored-by: Amanda Tarafa Mas <[email protected]>
Co-authored-by: Amanda Tarafa Mas <[email protected]>
jskeet
reviewed
Sep 18, 2023
|
To the folks CC'd, I'd like to put a review goal of End of Week on this if possible. It is necessary to unblock the supporting work I have lined up for publishing all of this. |
jskeet
approved these changes
Sep 19, 2023
andrei-scripniciuc
approved these changes
Sep 19, 2023
|
@loudej @slevenick @amanda-tarafa one more bump on this. I plan to submit it EoW if there is no other feedback. |
slevenick
approved these changes
Sep 20, 2023
noahdietz
dismissed
loudej’s stale review
Resolved offline, many others have approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce AIP-202 (chosen as one previous of AIP-203 regarding
google.api.field_behavior) to provide guidance on the usage of the forthcominggoogle.api.Fieldtype andgoogle.api.fieldextension.This will support the in progress AIP-129 and further support a future change to AIP-155.
Internal bug http://b/300315543