-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring autonomous processes events #646
Draft
Ezpeon
wants to merge
20
commits into
autonomous_processes_events
Choose a base branch
from
refactoring_autonomous_processes_events
base: autonomous_processes_events
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactoring autonomous processes events #646
Ezpeon
wants to merge
20
commits into
autonomous_processes_events
from
refactoring_autonomous_processes_events
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvalentini
changed the base branch from
master
to
autonomous_processes_events
November 29, 2024 11:04
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## autonomous_processes_events #646 +/- ##
===============================================================
+ Coverage 85.38% 85.42% +0.03%
===============================================================
Files 204 207 +3
Lines 27653 27801 +148
===============================================================
+ Hits 23611 23748 +137
- Misses 4042 4053 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started trying to refactor some of the code in PR #629
My goal was to cleanly separate the actions from the natural transitions as they are a bit different from a modeling perspective and this was not reflected in various representations.
This is not yet complete, but any suggestions about whether what I am doing makes sense is appreciated.