Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: computations warning #578

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

IsaccoSordo
Copy link
Collaborator

@IsaccoSordo IsaccoSordo commented Sep 6, 2023

In SolidJS, computations and cleanups should be created within a component that is being rendered.
However with our approach only whatever is inside the dispose function is actually called with the render method.
To resolve this warning, you can wrap your component in a createRoot or render function.

@IsaccoSordo IsaccoSordo self-assigned this Sep 7, 2023
@AndreasGassmann AndreasGassmann merged commit bfe8878 into develop Sep 28, 2023
3 checks passed
@AndreasGassmann AndreasGassmann deleted the fix/computations_warning branch September 28, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants