Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add machine comparison list for published results #1220

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qunaibit
Copy link

ASV tracks performance regression and improvements per machine and python versions. However, tracking performance on multiple configurations/optimizations options for python builds can only be done as separate machines configurations. Though, comparing machines against each other is only visible per benchmark view.

This PR will provide a comparison list for machines against each other. It can, also, exports the comparison list to markdown format (example).

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Probably better if you implement this as a third-party package. Not only because the copyright, also because asv is mostly unmaintained, and the last thing we want is even more code to maintain in it.

@@ -1,4 +1,5 @@
Copyright (c) 2011-2018, Michael Droettboom, Space Telescope Science Institute, Pauli Virtanen
Copyright (c) 2022, Oracle and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely not merging with this.

@mattip
Copy link
Contributor

mattip commented Feb 20, 2023

@qunaibit would you like to continue with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants