Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of hashTypeData for code clarity and check chain ID #1318

Merged
merged 12 commits into from
Aug 28, 2024

Conversation

smartcontrart
Copy link
Contributor

No description provided.

Copy link

openzeppelin-code bot commented Jul 5, 2024

Use of hashTypeData for code clarity and check chain ID

Generated at commit: b9b7ecf5905a251afee510d82865f7a15e80f270

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
7
25
34
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dmosites
Copy link
Contributor

Please remove ChainIdChanged from the interfaces and reduce MAX_ERROR_COUNT by one.

@dmosites dmosites merged commit fd9a894 into develop Aug 28, 2024
1 check passed
dmosites added a commit that referenced this pull request Aug 28, 2024
* Use of hashTypeData for code clarity and check chain ID (#1318)

* publish libraries 4.2.1-beta.0

* Removed redundant chain ID checks

* Removed unused error and reduced max_error count by one

* Removed unused error from swap and reduced MAX_ERROR by 1

---------

Co-authored-by: don mosites <[email protected]>

* naming, comments, adjustments

* Updated NatSpec

---------

Co-authored-by: Smartcontrart <[email protected]>
Co-authored-by: Smart Contrart <[email protected]>
@dmosites dmosites deleted the refactor/hash-typed-data branch November 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants