Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

853: Clicking "Back" during pending transaction should reset #886

Merged
1 commit merged into from
Mar 27, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2024

Fixes #853

Screen.Recording.2024-03-16.at.23.01.22.mov

Fixed for Make, Take and RFQ widget.

When clicking back from approve or wrap it takes you back to the start screen. Removed any loading state in start screen so user is free to go back to approve or wrap screen or change the query.

Resetting the query is not necessary I think but could still add that if necessary.

@ghost ghost requested a review from dmosites March 16, 2024 22:11
Copy link
Contributor

@dmosites dmosites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit febac1d into develop Mar 27, 2024
3 checks passed
@ghost ghost deleted the feature/853 branch March 27, 2024 15:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFQ, OTC: Clicking "Back" during pending transaction should reset
1 participant