869: Speeding up the tx changes the tx id and is not tracked #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 2, 2024 21:52
…eFromEvents, useLatestDepositOrWithdrawFromEvents, useLastSucceededTransaction, useLatestSwapFromEvents hooks.
ghost
requested review from
dmosites
approved these changes
Apr 17, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #869
Transactions are now tracked differently to account for hash changes.
Normally after a transaction is submitted it will use the hash to listen for a successful receipt. The problem is that the hash will change when you speed up a transaction.
I have a rewritten the whole listening part. Now it always listens for all events (swap, cancel, approve, deposit, withdrawal) and it will try to match it with any processing transaction in the store. It will first try to match with a hash, but if that fails it checks for matching attributes like order nonce, or amount.
If there's a match then the transaction is complete (or failed) and other actions can be fired from that, like show a toast.
Everything is consolidated in src/features/transactions/transactionsHooks.ts, I've also added some comments in there to make everything clear.
I've also done some refactoring.