Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

899: Added quotes store for LastLook and RFQ pricing #901

Merged
17 commits merged into from
May 2, 2024
Merged

899: Added quotes store for LastLook and RFQ pricing #901

17 commits merged into from
May 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2024 •
edited by ghost
Loading

Fixes #899

  • Moved all logic for RFQ and LastLook pricing in the quotes store and useQuotes hook.
  • Added a debug mode, type "debug" and you can disable RFQ or LastLook for better testing.
  • Added logging when in debug mode.
  • Cleanup of legacy code
  • Discovered that gas api is broken which is needed for LastLook order calculation, will fix next: Fix gas store api #900
rfq.mov
debug.mov

@ghost ghost requested review from dmosites, gpxl-dev and mikestarrdev April 29, 2024 21:03
@ghost ghost force-pushed the feature/899 branch from 7ddbfe8 to 1bfb983 Compare May 1, 2024 21:09
dmosites
dmosites approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@dmosites dmosites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 275e90b into develop May 2, 2024
3 checks passed
@ghost ghost deleted the feature/899 branch May 2, 2024 20:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpxl-dev gpxl-dev Awaiting requested review from gpxl-dev

@mikestarrdev mikestarrdev Awaiting requested review from mikestarrdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add quotes store for RFQ and LastLook orders
1 participant
@dmosites