Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Exactly-once delivery for MM2 #563

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Nov 13, 2024

Describe your changes

Added content for exactly-once delivery configuration for Aiven for Kafka MirrorMaker 2.

Preview - https://harshini-mm2-exactly-once-de.aiven-docs.pages.dev/docs/products/kafka/kafka-mirrormaker/howto/exactly-once-delivery

EC-446

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@harshini-rangaswamy harshini-rangaswamy self-assigned this Nov 13, 2024
@github-actions github-actions bot added service/kafka tech Relates to technical updates of the docs platform. service/kafka_mirrormaker labels Nov 13, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 13, 2024

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c71e339
Status: ✅  Deploy successful!
Preview URL: https://0f34cdae.aiven-docs.pages.dev
Branch Preview URL: https://harshini-mm2-exactly-once-de.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy added the review/SME An SME must review the PR. label Nov 14, 2024
@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review November 20, 2024 13:06
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner November 20, 2024 13:06
Copy link

@nosahama nosahama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@harshini-rangaswamy harshini-rangaswamy added review/TW A TW must review the PR. Comes after review/SME. and removed review/SME An SME must review the PR. labels Nov 20, 2024
exactly-once delivery.

</TabItem>
<TabItem value="terraform" label="Terraform">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we definitely want to include this sample in the Aiven Docs? We have information on the fields in our Terraform documentation, so this would be duplicating info.

This seems like a lot to document for one field. I wouldn't include things like a variables file here since if/how a user does this depends on their setup, internal guidelines, etc. We could instead add this field to the example usage in the TF docs if you think that would be helpful. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @staceysalamon-aiven! I agree that the original example was too detailed for a single field, so I’ve simplified it. However, I believe it’s important to include Terraform steps here for the operation, as they provide immediate value to users. A link to the Terraform provider documentation is also included for those who need more detailed information.
cc: @ArthurFlag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review/TW A TW must review the PR. Comes after review/SME. service/kafka_mirrormaker service/kafka tech Relates to technical updates of the docs platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants