Added normalize transform option to normalize string spaces #217
Conversation
src/definitions/transform.ts
Outdated
| @@ -26,6 +27,7 @@ const transform: {[key in TransformName]: Transform} = { | |||
| toLowerCase: (s) => s.toLowerCase(), | |||
| toUpperCase: (s) => s.toUpperCase(), | |||
| toEnumCase: (s, cfg) => cfg?.hash[configKey(s)] || s, | |||
| normalize: (s) => s.replace(/\s\s+/g, " "), | |||
There was a problem hiding this comment.
...or [\s\t]+ if tabs were to be included too
There was a problem hiding this comment.
because \s+ means single space or more, and in my case i want to only check multiple spaces and reduce them to one space
There was a problem hiding this comment.
also, pretty much the regex \s\s+ catters for all spaces, tabs and line breaks, maybe i add more tests for these other scenarios, but will also improve the regex to /(\s\s+)|\t|\n/ for our own peace of mind
There was a problem hiding this comment.
The performance of replacing /\s+/ can be better than /\s\s+/ and the result will be exactly the same.
There was a problem hiding this comment.
check my latest commits, i have resolved these issues and also added trimInner option
README.md
Outdated
| @@ -220,6 +220,7 @@ A standalone string cannot be modified, i.e. `data = 'a'; ajv.validate(schema, d | |||
| - `toLowerCase`: convert to lower case | |||
| - `toUpperCase`: convert to upper case | |||
| - `toEnumCase`: change string case to be equal to one of `enum` values in the schema | |||
| - `normalize`: replace inner multiple spaces with a single space | |||
There was a problem hiding this comment.
The name is too generic for what it does... Possible alternative - trimInner (and should it not replace tabs too?).
Any better ideas?
There was a problem hiding this comment.
word trim means to remove space, this just removes extra spaces, its not a bad idea though to also include remove spaces completely, with trimInner and come up with a better name for this one like normalizeSpaces
There was a problem hiding this comment.
let's please not conflate two different things into on PR.
I don't know the use case for removing all inner spaces tbh, normalizeSpaces is ok though.
There was a problem hiding this comment.
ok, will separate the other one in a different PR, will make another commit today
I added a normalize option for transform, a normalize option just basically removes multiple spaces and replaces them with a single space, I have been custom doing this in my previous projects and I thought this might be useful