Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): bump windows WindowsTargetPlatform #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TatianaKapos
Copy link

In RNW .72, we bump WinUI from 2.7 to 2.8 which targets a higher TargetPlatformMinVersion. This PR bumps the WindowsTargetPlatformMinVersion to the correct version for RNW .72

@TatianaKapos
Copy link
Author

@ak1394 would you mind looking at this PR when you have the chance? :) It blocks RNW apps from using .72

@ak1394
Copy link
Owner

ak1394 commented Jul 6, 2023

Hi @TatianaKapos ! Sure, I'll merge it. But using a chance to talk to someone at MS, I wanted to see if anyone on your side would be interested in updating the example app? It has been contributed by MS folks and I think it needs an update. Otherwise I'm going to remove it.

@TatianaKapos
Copy link
Author

@ak1394 just put a PR out to bump the RNW version of the example app to .72! I only had the time/resources to bump the windows side of the app, you'll probably want to double check the IOS/Android version of the app if those are important to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants