tracing and endpoint baseclass forward from main #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Improved custom tracing span API * Drop the tracing context, provide access to parent span if needed, update docs * Improved javadoc * review feedback --------- Co-authored-by: Johan Andrén <[email protected]>
* feat: Http endpoint base class with request context access # Conflicts: # akka-javasdk/src/main/java/akka/javasdk/http/RequestContext.java # akka-javasdk/src/main/scala/akka/javasdk/impl/SdkRunner.scala * post rebase fixes * formatting...
|
Is this handled by the full merge in #114 or were there any special tweaks? |
|
I'm a bit unsure, I'll take a look and close if covered |
|
Looks like this is all covered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't squash