This repository has been archived by the owner on Nov 8, 2019. It is now read-only.
OAuthBundle - portabilité between Symfony older than 2.6 and newest #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accepted |
|
Hey, thanks for opening the PR. Could you please extend the PR's body by some information what you did and why? That would be helpful. :) EDIT: What do you mean by "Accepted" though? EDIT 2: This branch breaks the test suite, could you please have a look on that one too? |
aklinkert
reviewed
Oct 19, 2017
| // to be removed when dependency on Symfony DependencyInjection is older than 2.6 | ||
| $definition->setFactoryService('apinnecke_oauth.service_factory'); | ||
| $definition->setFactoryMethod('createService'); | ||
| } | ||
| $definition->setFactory(array(new Reference('apinnecke_oauth.service_factory'), 'createService')); |
There was a problem hiding this comment.
This line should be removed, since it was moved inside the if clause
…rvice_factory'), 'createService'));
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.