Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Close security gaps OIDC implementation to make it work with Okta #2916

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Close security gaps OIDC implementation to make it work with Okta #2916

wants to merge 2 commits into from

Commits on Nov 12, 2024

  1. feat: Add OIDC State 

    When using PKCE it is recommended to send and validate a state variable to make sure the response fits. While this is not required by the specification, it is recommended, and turns out to be required by some implementations so doing it.

Signed-off-by: Stefan Richter <[email protected]>
    @02strich
    02strich committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2a094f2 View commit details
    Browse the repository at this point in the history

  2. feat: Remove forced offline_access scope 

    The offline_access scope is considered to be a security concern when used in web apps by some people. This leads to some OIDC implementations enforcing it to not be used. Anyone who needs it/would like to use it, can configure to add it again.

Signed-off-by: Stefan Richter <[email protected]>
    @02strich
    02strich committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f415100 View commit details
    Browse the repository at this point in the history