Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: manual rolebindings for global namespaces #2934

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fykaa
Copy link
Contributor

@fykaa fykaa commented Nov 15, 2024

closes #2834

@fykaa fykaa self-assigned this Nov 15, 2024
@fykaa fykaa requested review from a team as code owners November 15, 2024 17:49
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit f100b88
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/673e732cc980770008b98a35
😎 Deploy Preview https://deploy-preview-2934.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.90%. Comparing base (aa66473) to head (f100b88).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
+ Coverage   49.97%   50.90%   +0.93%     
==========================================
  Files         276      279       +3     
  Lines       24811    25178     +367     
==========================================
+ Hits        12400    12818     +418     
+ Misses      11724    11669      -55     
- Partials      687      691       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@@ -5,7 +5,7 @@ sidebar_label: Managing credentials

# Managing Credentials

To manage the progression of freight from stage to stage, Kargo will often
To manage the progression of `Freight` from `Stage` to `Stage`, Kargo will often
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes to uppercase here, but probably wouldn't monospace here.

Suggested change
To manage the progression of `Freight` from `Stage` to `Stage`, Kargo will often
To manage the progression of Freight from Stage to Stage, Kargo will often

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fykaa
Copy link
Contributor Author

fykaa commented Nov 15, 2024

There is a Caution text right in the end of Global credentials section, It should give an implication of warning for enabling cluster-wide secrets

Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Faeka Ansari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: need to mention need for manual rolebindings in global credential namespaces
2 participants