Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warehouse selection strategies #2963

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fykaa
Copy link
Contributor

@fykaa fykaa commented Nov 19, 2024

closes #2880

This addresses the aforementioned problem in its broadest sense.

However, we would prefer to have a separate "Working with Warehouses" guide in the long run, which can be completed within this PR.

@fykaa fykaa self-assigned this Nov 19, 2024
@fykaa fykaa requested review from a team as code owners November 19, 2024 14:17
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 40dd06f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/673ca11ac0ddf60008dcbb10
😎 Deploy Preview https://deploy-preview-2963.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.91%. Comparing base (34c6128) to head (40dd06f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2963      +/-   ##
==========================================
- Coverage   50.92%   50.91%   -0.01%     
==========================================
  Files         279      279              
  Lines       25180    25175       -5     
==========================================
- Hits        12823    12818       -5     
  Misses      11666    11666              
  Partials      691      691              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fykaa
Copy link
Contributor Author

fykaa commented Nov 19, 2024

However, we would prefer to have a separate "Working with Warehouses" guide in the long run, which can be completed within this PR.

I addressed this under commit 40dd06f. If it's not necessary for this PR, I can revert the commit.

@krancour
Copy link
Member

@fykaa I can look at this, but the more immediate solution I was hoping for were comments added to relevant fields in warehouse_types.go and then codegen re-run. i.e. I want info currently not surfaced here and here to be surfaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the possible values of Warehouse imageSelectionStrategy
2 participants