Revert "Accept references for set_contents"
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisduerr
approved these changes
Oct 12, 2023
When using generic in a trait the trait becomes not object-safe forcing generics or static dispatch in a such code. For a crate like copypasta that's something we don't really want to, since it's usually self-contained and has different clipboard providers. This reverts commit 10f1137.
kchibisov
force-pushed
the
revert-content
branch
from
0bae16e to
f293054
Compare
chrisduerr
approved these changes
Oct 12, 2023
|
Sorry for bothering, and thank you for reverting the commit. |
|
Should have been caught during review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using generic in a trait the trait becomes not object-safe forcing generics or static dispatch in a such code. For a crate like copypasta that's something we don't really want to, since it's usually self-contained and has different clipboard providers.
This reverts commit 10f1137.