Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow reconfiguring via options #2319

Merged
merged 37 commits into from
Jul 18, 2024
Merged

feat: allow reconfiguring via options #2319

merged 37 commits into from
Jul 18, 2024

Conversation

danielbrunt57
Copy link
Collaborator

image

image

      {
        "data": {
          "url": "amazon.com",
          "otp_secret": "<redacted>",
          "email": "[email protected]",
          "password": "<redacted>",
          "scan_interval": 60,
          "queue_delay": 1.5,
          "include_devices": "",
          "exclude_devices": "",
          "extended_entity_discovery": false,
          "debug": true,
          "oauth": {
            "access_token": <redacted>,
            "refresh_token": "<redacted>,
            "expires_in": 1721087733.087414,
            "mac_dms": {
              "device_private_key": <redacted>,
              "adp_token": <redacted>
            },
            "code_verifier": <redacted>,
            "authorization_code": <redacted>
          }
        },
        "disabled_by": null,
        "domain": "alexa_media",
        "entry_id": "01J2W9QF31DJEFJ3QQY8VHM1FT",
        "minor_version": 1,
        "options": {},
        "pref_disable_new_entities": false,
        "pref_disable_polling": false,
        "source": "user",
        "title": "[email protected] - amazon.com",
        "unique_id": "[email protected] - amazon.com",
        "version": 1
      }

__init__.py Outdated Show resolved Hide resolved
@danielbrunt57
Copy link
Collaborator Author

It was the result of a NOOB error!
I accidentally uploaded custom_components/alexa/meda/ to root and missed removing that one!

"hide_default_branch": true
hacs.json Outdated Show resolved Hide resolved
hacs.json Outdated Show resolved Hide resolved
custom_components/alexa_media/config_flow.py Outdated Show resolved Hide resolved
custom_components/alexa_media/config_flow.py Outdated Show resolved Hide resolved
@alandtse
Copy link
Owner

You're not providing valid json. Please use a linter/validator. https://jsonformatter.curiousconcept.com/

Thank you for the JSON Formatter & Validator!
@danielbrunt57
Copy link
Collaborator Author

Please use a linter/validator. https://jsonformatter.curiousconcept.com/

That helps immensely!

@danielbrunt57
Copy link
Collaborator Author

I've translated my strings.json file to all 14 additional languages (via https://translate.i18next.com/).
Should I update my dev branch that this PR is targeting or just let this PR complete first?

@alandtse
Copy link
Owner

Your translations will get clobbered automatically. As mentioned, we use lokalise and that is pulled on release.

@danielbrunt57
Copy link
Collaborator Author

Ah, thanks for the info. I did not know it was automatic.

@alandtse alandtse closed this Jul 18, 2024
@alandtse alandtse reopened this Jul 18, 2024
@alandtse
Copy link
Owner

Noticed you didn't use black on your code. I forgot the pre-commit action was disabled as that should also help format your code.

@alandtse alandtse changed the title Enhancement to permit configuring/reconfiguring all available options feat: allow reconfiguring via options Jul 18, 2024
@alandtse alandtse merged commit 8908b38 into alandtse:dev Jul 18, 2024
2 of 3 checks passed
@danielbrunt57
Copy link
Collaborator Author

danielbrunt57 commented Jul 18, 2024

Noticed you didn't use black on your code.

What is "black"?

  • Update - I googled it and gained a bit of an insight. I didn't set up a developer environment. I just did this on my live system...

@danielbrunt57
Copy link
Collaborator Author

Now that this is done, I was thinking of removing service.clear_history since it stopped working Oct 2023.
Your thoughts?

image

@alandtse
Copy link
Owner

https://github.com/psf/black. If it's truly deprecated we can remove it.

@danielbrunt57
Copy link
Collaborator Author

If it's truly deprecated we can remove it.

I last cleared my voice history in Alexa on July 9th. Just tried running the service 4 times and all of the voice history is still there...

@danielbrunt57
Copy link
Collaborator Author

I've edited the wiki as a 1st step:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants