Add hardhat task to update programs. #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaintextpaco
requested changes
Jan 17, 2023
There was a problem hiding this comment.
describe("WHEN adding it with the add-program task, AND passing all parameters", () => {
it("THEN it is listed", async () => {
it("WHEN updates the program using update-program", () => {
it("WHEN updates name and url", async () => {
it("WHEN updates only name", async () => {
it("WHEN updates only url", async () => {
should be:
describe("WHEN adding it with the add-program task, AND passing all parameters", () => {
it("THEN it is listed", async () => {
describe("WHEN updating both name and url with the update-program task", () => {
it("THEN the name changed")
it("AND the url changed")
describe("WHEN updating only the name with the update-program task")
it("THEN the name changed")
it("AND the url is kept")
describe("WHEN updating only the url with the update-program task")
it("THEN the url changed")
it("AND the name is kept")
or at least:
describe("WHEN adding it with the add-program task, AND passing all parameters", () => {
it("THEN it is listed", async () => {
describe("update-program task", () => {
it("WHEN updating name and url THEN they are both modified", async () => {
it("WHEN updating only name THEN only the name changes AND the original url is kept", async () => {
it("WHEN updating only url THEN only the url changes AND the original name is kept", async () => {
also, there's the missing testcase of not passing any of the optional flags
plaintextpaco
requested changes
Jan 19, 2023
itirabasso
force-pushed
the
update-program
branch
3 times, most recently
from
8096873 to
ae68b58
Compare
plaintextpaco
requested changes
Jan 23, 2023
test/deployments.ts
Outdated
| expect(updatedProgram.startTime).to.eq(program.startTime); | ||
| }); | ||
| }); | ||
| describe("AND updates url", async () => { |
There was a problem hiding this comment.
fix the grammar of the descriptions.
this should perhaps be AND WHEN updating only the url
The test logs are harder to follow otherwise
There was a problem hiding this comment.
wouldn't WHEN be redundant?
WHEN updates the program using update-program
AND updates the name
✓ THEN only the name is changed
There was a problem hiding this comment.
have you taken the previous feedback into account?
itirabasso
force-pushed
the
update-program
branch
from
ae68b58 to
54f8f64
Compare
use proper WHEN-THEN syntaxis update tests grammar
itirabasso
force-pushed
the
update-program
branch
from
54f8f64 to
7db71d0
Compare
fix throw message error
yarn lint-ts
itirabasso
force-pushed
the
update-program
branch
from
7db71d0 to
632a0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.