Skip to content

Commit

Permalink
fix(pool): don't log an error during validation failure in gas check (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
dancoombs authored Nov 25, 2024
1 parent 663a373 commit 6817ed7
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ jobs:
cache-on-failure: true
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
# Build to generate the ABI bindings.
with:
version: "nightly-fe2acca4e379793539db80e032d76ffe0110298b"

# Build to generate the ABI bindings.
- name: cargo build
uses: actions-rs/cargo@v1
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/compliance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ jobs:

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: "nightly-fe2acca4e379793539db80e032d76ffe0110298b"

- uses: KengoTODA/actions-setup-docker-compose@v1
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ jobs:
- name: Foundry install
if: contains( ${{ matrix.target }}, 'apple')
uses: foundry-rs/foundry-toolchain@v1
with:
version: "nightly-fe2acca4e379793539db80e032d76ffe0110298b"

- name: Install protobuf
if: contains( ${{ matrix.target }}, 'apple')
uses: arduino/setup-protoc@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/unit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: "nightly-fe2acca4e379793539db80e032d76ffe0110298b"

- name: Install latest nextest release
uses: taiki-e/install-action@nextest
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN apt-get update && apt-get -y upgrade && apt-get install -y libclang-dev pkg-
SHELL ["/bin/bash", "-c"]
RUN curl -L https://foundry.paradigm.xyz | bash
ENV PATH="/root/.foundry/bin:${PATH}"
RUN foundryup
RUN foundryup -v nightly-fe2acca4e379793539db80e032d76ffe0110298b

RUN cargo install cargo-chef --locked

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.build
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG CROSS_BASE_IMAGE

FROM ghcr.io/foundry-rs/foundry:nightly-ac802618e15039b31e464ae6d1fe3ee39f87cefd as foundry
FROM ghcr.io/foundry-rs/foundry:nightly-fe2acca4e379793539db80e032d76ffe0110298b as foundry

FROM $CROSS_BASE_IMAGE
COPY --from=foundry /usr/local/bin/forge /usr/local/bin/forge
Expand Down
5 changes: 4 additions & 1 deletion crates/pool/src/mempool/uo_pool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,10 @@ where
tracing::error!("Failed to simulate handle op for gas limit efficiency check, failing open: {:?}", e);
}
Ok(Err(e)) => {
tracing::error!("Failed to simulate handle op for gas limit efficiency check, failing open: {:?}", e);
tracing::debug!(
"Validation error during gas limit efficiency check, failing open: {:?}",
e
);
}
Ok(Ok(execution_res)) => {
let total_gas_used: u128 = (execution_res.paid / U256::from(gas_price))
Expand Down

0 comments on commit 6817ed7

Please sign in to comment.