refactor: rework the pool server classes #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
commented
Aug 24, 2023
dancoombs
commented
Aug 24, 2023
dancoombs
commented
Aug 24, 2023
dancoombs
commented
Aug 24, 2023
Comment on lines
+339
to
+364
| ServerRequestKind::AddOp { entry_point, op, origin } => { | ||
| match self.get_pool(entry_point) { | ||
| Ok(mempool) => { | ||
| let mempool = Arc::clone(mempool); | ||
| tokio::spawn(async move { | ||
| let resp = match mempool.add_operation(origin, op).await { | ||
| Ok(hash) => Ok(ServerResponse::AddOp { hash }), | ||
| Err(e) => Err(e.into()), | ||
| }; | ||
| if let Err(e) = req.response.send(resp) { | ||
| tracing::error!("Failed to send response: {:?}", e); | ||
| } | ||
| }); | ||
| continue; | ||
| }, | ||
| Err(e) => Err(e), | ||
| } | ||
| }, |
There was a problem hiding this comment.
This is the only long running task, so we need to spawn it to make space for the actor thread to continue processing requests.
dancoombs
commented
Aug 24, 2023
dphilipson
reviewed
Aug 26, 2023
dancoombs
force-pushed
the
danc/simplify-local-remote
branch
from
49809d9 to
0412b5c
Compare
dancoombs
force-pushed
the
danc/pool-stream
branch
from
7210e9c to
c9e9c6c
Compare
dancoombs
force-pushed
the
danc/pool-stream
branch
7 times, most recently
from
4ec2ff7 to
3e21b0e
Compare
dancoombs
force-pushed
the
danc/simplify-local-remote
branch
2 times, most recently
from
23c3285 to
f489dca
Compare
dphilipson
approved these changes
Sep 6, 2023
0xfourzerofour
approved these changes
Sep 7, 2023
dancoombs
force-pushed
the
danc/simplify-local-remote
branch
from
f489dca to
49dd555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.