fix(gas): amortize evm transaction fixed cost over bundle #442
Conversation
alex-miao
requested review from
dancoombs,
dphilipson and
0xfourzerofour
as code owners
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| where | ||
| I: Iterator<Item = &'a UserOperation>, | ||
| { | ||
| let ov = GasOverheads::default(); |
There was a problem hiding this comment.
somewhat unnecessary duplication since we are creating the GasOverheads object both here and within user_operation_gas_limit, but favoring this over needing to make GasOverheads public.
There was a problem hiding this comment.
Since we're doing this here, we might as well do the same thing in calc_static_pre_verification_gas?
Either we make it part of both the interfaces, or we instantiate in each.
Again I eventually want these to look like bundle_gas_limit<C: ChainSpec> and then you can get these constants off of the chain spec.
| + U256::from(5_000) | ||
| + U256::from(21_000), |
There was a problem hiding this comment.
Is it possible to get these from some common place? Tests will break if we ever modify these values.
These are the sorts of things I want to move to the ChainSpec config class in the future.
There was a problem hiding this comment.
Changed to exposing the relevant fields of GasOverheads, it's not great but just avoiding a major refactor for now.
#349
Proposed Changes