Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rust 1.73.0 fixes #458

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: rust 1.73.0 fixes #458

merged 1 commit into from
Oct 6, 2023

Conversation

dancoombs
Copy link
Collaborator

No description provided.

0xfourzerofour
0xfourzerofour approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #458 (f031a47) into main (b337dcb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Coverage Δ
crates/pool/src/chain.rs 90.17% <100.00%> (-0.02%) ⬇️
crates/sim/src/estimation/estimation.rs 90.61% <ø> (-0.01%) ⬇️
Flag Coverage Δ
unit-tests 52.28% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 45.07% <ø> (ø)
dev 0.00% <ø> (ø)
pool 59.63% <100.00%> (-0.02%) ⬇️
provider 1.33% <ø> (ø)
rpc 18.51% <ø> (ø)
sim 82.61% <ø> (-0.01%) ⬇️
tasks ∅ <ø> (∅)
types 93.56% <ø> (ø)
utils 7.20% <ø> (ø)

@dancoombs dancoombs merged commit f1c3f5d into main Oct 6, 2023
7 checks passed
@dancoombs dancoombs deleted the danc/fix-redundant branch October 6, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancoombs @0xfourzerofour