feat(network): start network impl and rpc handling #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
requested review from
dphilipson,
0xfourzerofour and
alex-miao
as code owners
dancoombs
force-pushed
the
danc/p2p-rpc
branch
from
794ea76 to
d796f44
Compare
|
Next up:
|
dancoombs
commented
Oct 11, 2023
| } | ||
| } | ||
| } | ||
| } |
Codecov Report
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dancoombs
force-pushed
the
danc/p2p-rpc
branch
from
d796f44 to
0eb3059
Compare
dancoombs
commented
Oct 11, 2023
|
|
||
| let transport = tcp::tokio::Transport::default() | ||
| .upgrade(upgrade::Version::V1Lazy) | ||
| .authenticate(noise::Config::new(&local_key).unwrap()) |
There was a problem hiding this comment.
TODO: remove these unwraps
dancoombs
commented
Oct 11, 2023
Comment on lines
+181
to
+182
| let mplex_config = libp2p_mplex::MplexConfig::new(); | ||
| let yamux_config = libp2p::yamux::Config::default(); |
There was a problem hiding this comment.
TODO: pass these in through config
alex-miao
reviewed
Oct 13, 2023
| use rundler_network::{Config as NetworkConfig, ConnectionConfig, Network}; | ||
| use tokio::sync::mpsc; | ||
|
|
||
| const PRIVATE_KEY: &str = "b0ddfec7d365b4599ff8367e960f8c4890364f99e2151beac352338cc0cfe1bc"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#248
Proposed Changes
Networkimplementation with the RPC behavior (sorry about the behaviour spelling, thats what libp2p uses to I was consistent).