Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pool): add back already known check after refactor #467

Merged
merged 1 commit into from
Oct 14, 2023
Merged

fix(pool): add back already known check after refactor #467

merged 1 commit into from
Oct 14, 2023

Conversation

dancoombs
Copy link
Collaborator

No description provided.

@dancoombs dancoombs force-pushed the danc/fix-already-known branch from b8fafb2 to 44eaf94 Compare October 14, 2023 13:37
0xfourzerofour
0xfourzerofour approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #467 (44eaf94) into main (d6b825c) will increase coverage by 0.13%.
The diff coverage is 91.54%.

Impacted file tree graph

Files Coverage Δ
crates/pool/src/mempool/pool.rs 97.01% <100.00%> (+0.63%) ⬆️
crates/pool/src/server/remote/client.rs 0.00% <ø> (ø)
crates/pool/src/mempool/uo_pool.rs 89.79% <88.67%> (-0.11%) ⬇️
Flag Coverage Δ
unit-tests 52.69% <91.54%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 47.98% <ø> (ø)
dev 0.00% <ø> (ø)
pool 59.92% <91.54%> (+0.37%) ⬆️
provider 1.33% <ø> (ø)
rpc 18.26% <ø> (ø)
sim 82.20% <ø> (ø)
tasks ∅ <ø> (∅)
types 93.56% <ø> (ø)
utils 7.20% <ø> (ø)

@dancoombs dancoombs merged commit 8592d35 into main Oct 14, 2023
7 checks passed
@dancoombs dancoombs deleted the danc/fix-already-known branch October 14, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancoombs @0xfourzerofour