Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pool): add basic structure for update entities pool operation #478

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

alex-miao
Copy link
Collaborator

Progress towards #451, #455, #454, #449

Proposed Changes

  • expose the update_entities call in the mempool that is mean't to replace remove_entities to allow for more flexibility in the types of updates the pool can handle

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #478 (f75e1fc) into main (ed31bd8) will decrease coverage by 0.59%.
The diff coverage is 4.67%.

Impacted file tree graph

Files Coverage Δ
crates/pool/src/mempool/mod.rs 97.50% <ø> (ø)
crates/pool/src/server/mod.rs 33.33% <ø> (ø)
crates/types/src/entity.rs 34.69% <0.00%> (-7.81%) ⬇️
crates/pool/src/server/remote/client.rs 0.00% <0.00%> (ø)
crates/pool/src/server/remote/protos.rs 4.87% <0.00%> (-0.84%) ⬇️
crates/pool/src/server/local.rs 50.96% <0.00%> (-3.77%) ⬇️
crates/pool/src/server/remote/server.rs 0.00% <0.00%> (ø)
crates/pool/src/mempool/uo_pool.rs 86.56% <0.00%> (-3.23%) ⬇️
crates/pool/src/mempool/reputation.rs 76.64% <21.62%> (-7.06%) ⬇️
Flag Coverage Δ
unit-tests 52.01% <4.67%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 47.67% <ø> (ø)
dev 0.00% <ø> (ø)
pool 57.78% <4.93%> (-2.14%) ⬇️
provider 1.33% <ø> (ø)
rpc 18.26% <ø> (ø)
sim 82.20% <ø> (ø)
tasks ∅ <ø> (∅)
types 91.66% <0.00%> (-1.90%) ⬇️
utils 7.20% <ø> (ø)

Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments

crates/pool/src/mempool/reputation.rs Outdated Show resolved Hide resolved
crates/pool/src/mempool/reputation.rs Outdated Show resolved Hide resolved
crates/types/src/entity.rs Outdated Show resolved Hide resolved
@alex-miao alex-miao merged commit 02d72c9 into main Nov 6, 2023
8 checks passed
@alex-miao alex-miao deleted the alex/update-entities branch November 6, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants