-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip #548
wip #548
Conversation
4152547
to
409d76c
Compare
Codecov ReportAttention:
Additional details and impacted files
... and 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
409d76c
to
e398bd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it.
#[derive(Deserialize, Default)] | ||
$vis struct [<Optional $struct_name>] { | ||
/// The base chain spec to use | ||
pub base: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be here? Is base
different from the other fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the idea was that during the optional phase you can define a base
that merges all configuration from that base configuration into yours, useful for testnets to inherit the config of the mainnet. This field goes away in the actual chain spec config.
e398bd8
to
d37767d
Compare
d37767d
to
7e4d569
Compare
[Closes/Fixes] #
Proposed Changes