feat: end to end entry point routing #649
Conversation
dancoombs
requested review from
dphilipson,
0xfourzerofour and
alex-miao
as code owners
dancoombs
changed the title
| match ep.version { | ||
| EntryPointVersion::V0_6 => { | ||
| let (handles, actions) = self | ||
| .create_builders_v0_6(ep, Arc::clone(&provider), ep_v0_6.clone()) |
There was a problem hiding this comment.
Because the provider is already cloned within the ep_v0_6 struct I wonder if we should add an inner function to provider so that we can remove the second arg and clone from within the create_builders_v0_6 function. Does not really change the logic but the less args the better IMO
There was a problem hiding this comment.
From an interface perspective I don't like this. Its possible in the future an entry point wouldn't have an inner provider, that is specific to the ethers implementation.
| @@ -255,6 +250,92 @@ where | |||
| Box::new(self) | |||
| } | |||
|
|
|||
| async fn create_builders_v0_6<C, E>( | |||
There was a problem hiding this comment.
We should add a todo here to merge these builder creator functions into one using generics based on the UO version once entrypoint v7 safe simulation is implemented
There was a problem hiding this comment.
Yeah I found the types a little difficult to work with to get a common function. Adding a TODO
crates/pool/src/task.rs
Outdated
| } | ||
|
|
||
| async fn create_mempool_v0_6<P: Provider + Middleware>( | ||
| fn create_mempool_v0_6<P: Provider + Middleware>( |
There was a problem hiding this comment.
Same thing here, it looks possible but need to play around with the code for this feature to make sure
| @@ -25,10 +25,20 @@ use crate::simulation::SimulationViolation; | |||
| /// Typically read from a JSON file using the `Deserialize` trait. | |||
| #[derive(Debug, Clone, Deserialize, Default)] | |||
| pub struct MempoolConfig { | |||
| /// Entry point address this mempool is associated with. | |||
| #[serde(rename = "camelCase")] | |||
| pub(crate) entry_point: Address, | |||
There was a problem hiding this comment.
Will we have to add multiple mempool configs per network based on entrypoint addresses now?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Proposed Changes
UNSAFEand a hardcoded gas estimator