Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): enforce num keys greater than or equal to num builders #697

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • On startup check that the configured number of keys is greater than or equal to the total number of builders across the two entrypoints.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 55.15%. Comparing base (f2f3dd8) to head (72781f0).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
bin/rundler/src/cli/builder.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 55.15% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 50.60% <ø> (ø)
dev 0.00% <ø> (ø)
pool 64.87% <ø> (ø)
provider 14.77% <ø> (ø)
rpc 25.46% <ø> (ø)
sim 77.53% <ø> (ø)
tasks ∅ <ø> (∅)
types 65.88% <ø> (ø)
utils 18.28% <ø> (ø)

Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dancoombs dancoombs merged commit 8eb4cb4 into main Apr 23, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/num-builders branch April 23, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants