Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simulation): don't use abi-generated EntryPoint bytecode #698

Closed
wants to merge 1 commit into from

Conversation

dphilipson
Copy link
Collaborator

This reverts commit 275414d.

We need the v0.6 entry point bytecode so we can use it in state overrides during call gas estimation. In a previous commit, we started using bytecode generated by abigen to avoid hardcoding the entry point bytecode or fetching it from on-chain on every run. For unknown reasons, the abigen bytecode is faulty and causes reverts with no data, so switch back to using hardcoded bytecode.

This reverts commit 275414d.

We need the v0.6 entry point bytecode so we can use it in state
overrides during call gas estimation. In a previous commit, we started
using bytecode generated by abigen to avoid hardcoding the entry point
bytecode or fetching it from on-chain on every run. For unknown reasons,
the abigen bytecode is faulty and causes reverts with no data, so switch
back to using hardcoded bytecode.
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.15%. Comparing base (8eb4cb4) to head (e6d9a59).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/pool/src/chain.rs 94.78% <100.00%> (ø)
crates/rpc/src/eth/api.rs 74.20% <100.00%> (ø)
crates/sim/src/estimation/mod.rs 80.00% <ø> (ø)
crates/sim/src/estimation/v0_6.rs 94.28% <100.00%> (ø)
crates/sim/src/simulation/v0_6/context.rs 65.58% <ø> (ø)
crates/types/src/user_operation/v0_6.rs 97.23% <ø> (ø)
crates/types/src/validation_results.rs 26.95% <ø> (ø)
crates/rpc/src/eth/events/v0_6.rs 17.85% <66.66%> (ø)
crates/dev/src/lib.rs 0.00% <0.00%> (ø)
crates/provider/src/ethers/entry_point/v0_6.rs 0.00% <0.00%> (ø)
... and 1 more
Flag Coverage Δ
unit-tests 55.15% <47.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 50.60% <ø> (ø)
dev 0.00% <0.00%> (ø)
pool 64.87% <100.00%> (ø)
provider 14.77% <0.00%> (ø)
rpc 25.46% <75.00%> (ø)
sim 77.53% <100.00%> (ø)
tasks ∅ <ø> (∅)
types 65.88% <ø> (ø)
utils 18.28% <ø> (ø)

@dancoombs dancoombs mentioned this pull request Apr 24, 2024
@dancoombs dancoombs closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants