-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(simulation): check whether the op fits within a valid time range #712
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0618e2f
to
28fc5db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We should add to our docs that we require a UO to be valid at least 1 minute in the future for acceptance into the mempool. This is important as an anti-DOS mechanism, we don't want to fill our mempool with UOs that are going to expire before bundling.
9d36ab6
to
0e210b7
Compare
Proposed Changes