Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(builder): add unit tests to bundle_sender #735

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

dancoombs
Copy link
Collaborator

Create a unit testing framework for bundle_sender and write some tests.

@dancoombs dancoombs force-pushed the danc/sender-tests branch 2 times, most recently from fdab175 to d15f35a Compare June 19, 2024 14:06
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, solid testing cases as well

@dancoombs dancoombs force-pushed the danc/sender-fixes branch from f01429f to e94744a Compare June 20, 2024 18:22
@dancoombs dancoombs force-pushed the danc/sender-tests branch from d15f35a to d5abafe Compare June 20, 2024 18:22
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 93.53846% with 42 lines in your changes missing coverage. Please review.

Project coverage is 57.15%. Comparing base (e94744a) to head (d5abafe).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/bundle_proposer.rs 90.37% <100.00%> (+4.16%) ⬆️
crates/builder/src/transaction_tracker.rs 81.17% <100.00%> (+0.03%) ⬆️
crates/builder/src/bundle_sender.rs 72.80% <92.30%> (+72.80%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
unit-tests 57.15% <93.53%> (+2.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 59.54% <93.53%> (+14.01%) ⬆️
dev 0.00% <ø> (ø)
pool 65.07% <ø> (ø)
provider 16.10% <ø> (ø)
rpc 25.66% <ø> (ø)
sim 78.13% <ø> (+0.26%) ⬆️
tasks ∅ <ø> (∅)
types 65.45% <ø> (ø)
utils 18.28% <ø> (ø)

@dancoombs dancoombs merged commit 16f7006 into danc/sender-fixes Jun 20, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/sender-tests branch June 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants