feat: switch to metrics_derive #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysim3d
requested review from
dancoombs,
dphilipson,
0xfourzerofour and
alex-miao
as code owners
andysim3d
force-pushed
the
andy/metric-derive
branch
2 times, most recently
from
d07ebca to
298870f
Compare
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
crates/pool/src/mempool/uo_pool.rs
Outdated
Comment on lines
710
to
732
| #[derive(Metrics)] | ||
| #[metrics(scope = "op_pool")] | ||
| struct UoPoolMetricsEPSpecific { | ||
| #[metric(describe = "the number of ops seen.")] | ||
| ops_seen: Gauge, | ||
| #[metric(describe = "the number of unmined ops.")] | ||
| unmined_operations: Counter, | ||
| #[metric(describe = "the number of removed ops.")] | ||
| removed_operations: Counter, | ||
| #[metric(describe = "the number of removed entities.")] | ||
| removed_entities: Counter, | ||
| } | ||
|
|
||
| fn current_base_fee(fee: f64) { | ||
| metrics::gauge!("op_pool_current_base_fee").set(fee); | ||
| } | ||
| #[derive(Metrics)] | ||
| #[metrics(scope = "op_pool")] | ||
| struct UoPoolMetrics { | ||
| #[metric(describe = "the maximum fee in Gwei.")] | ||
| current_max_fee_gwei: Gauge, | ||
| #[metric(describe = "the maximum priority fee in Gwei.")] | ||
| current_max_priority_fee_gwei: Gauge, | ||
| #[metric(describe = "the base fee of current block.")] | ||
| current_base_fee: Gauge, | ||
| } |
There was a problem hiding this comment.
What do you think about simplifying this into a single struct and just handling the duplication of the fees in dashboards?
There was a problem hiding this comment.
that might confuse who don't familiar the metric setup. they might find the value doubled (for 2 EPs we supportted.)
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
dancoombs
reviewed
Oct 11, 2024
andysim3d
force-pushed
the
andy/metric-derive
branch
from
8c9e405 to
9ab1dfd
Compare
dancoombs
pushed a commit
that referenced
this pull request
Oct 18, 2024
dancoombs
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Closes/Fixes] #166
Proposed Changes