Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pool): don't log an error during validation failure in gas check #915

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(pool): don't log an error during validation failure in gas check #915

merged 1 commit into from
Nov 25, 2024

Conversation

dancoombs
Copy link
Collaborator

PR to main: #914

0xfourzerofour
0xfourzerofour previously approved these changes Nov 24, 2024
View reviewed changes
@dancoombs dancoombs force-pushed the danc/fix-pool-error-log branch 4 times, most recently from 28660ee to a5e81bd Compare November 24, 2024 16:09
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.67%. Comparing base (a92183b) to head (d1217ee).
Report is 1 commits behind head on release/v0.4.

Files with missing lines Patch % Lines
crates/pool/src/mempool/uo_pool.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/uo_pool.rs 92.55% <0.00%> (-0.06%) ⬇️
Flag Coverage Δ
unit-tests 58.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 62.97% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.73% <0.00%> (-0.01%) ⬇️
provider 20.84% <ø> (ø)
rpc 25.87% <ø> (ø)
sim 76.76% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.83% <ø> (ø)
utils 29.38% <ø> (ø)
---- 🚨 Try these New Features:

@dancoombs dancoombs force-pushed the danc/fix-pool-error-log branch 2 times, most recently from bde9f8c to 23b5591 Compare November 25, 2024 14:33
@dancoombs dancoombs force-pushed the danc/fix-pool-error-log branch from 23b5591 to d1217ee Compare November 25, 2024 14:46
@dancoombs dancoombs merged commit ef7cd32 into release/v0.4 Nov 25, 2024
10 checks passed
@dancoombs dancoombs deleted the danc/fix-pool-error-log branch November 25, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

@andysim3d andysim3d Awaiting requested review from andysim3d andysim3d is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancoombs @0xfourzerofour