Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): fix reth tx sender errors #921

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(builder): fix reth tx sender errors #921

merged 1 commit into from
Nov 25, 2024

Conversation

dancoombs
Copy link
Collaborator

Picked from #920

@dancoombs dancoombs mentioned this pull request Nov 25, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.09%. Comparing base (db86d73) to head (42240a2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/builder/src/sender/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/builder/src/sender/mod.rs 1.33% <0.00%> (+0.05%) ⬆️
Flag Coverage Δ
unit-tests 59.09% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 64.85% <0.00%> (+0.03%) ⬆️
dev ∅ <ø> (∅)
pool 66.64% <ø> (ø)
provider 20.84% <ø> (ø)
rpc 25.87% <ø> (ø)
sim 76.76% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.81% <ø> (ø)
utils 31.73% <ø> (ø)
---- 🚨 Try these New Features:

@dancoombs dancoombs merged commit d283ce1 into main Nov 25, 2024
11 checks passed
@dancoombs dancoombs deleted the danc/fix-reth-error-pick branch November 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysim3d andysim3d andysim3d approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@0xfourzerofour 0xfourzerofour Awaiting requested review from 0xfourzerofour 0xfourzerofour is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancoombs @andysim3d