Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: impl timeout layer. #926

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: impl timeout layer. #926

merged 3 commits into from
Dec 19, 2024

Conversation

andysim3d
Copy link
Collaborator

[Closes/Fixes] #

Proposed Changes

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 24 lines in your changes missing coverage. Please review.

Project coverage is 59.50%. Comparing base (0e39305) to head (6eda480).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/builder/src/sender/mod.rs 0.00% 7 Missing ⚠️
crates/provider/src/alloy/mod.rs 85.00% 6 Missing ⚠️
crates/builder/src/task.rs 0.00% 5 Missing ⚠️
bin/rundler/src/cli/builder.rs 0.00% 3 Missing ⚠️
bin/rundler/src/cli/mod.rs 0.00% 2 Missing ⚠️
crates/provider/src/alloy/provider_timeout.rs 97.72% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/provider/src/alloy/metrics.rs 57.57% <100.00%> (+57.57%) ⬆️
crates/types/src/task/status_code.rs 0.00% <ø> (ø)
crates/provider/src/alloy/provider_timeout.rs 97.72% <97.72%> (ø)
bin/rundler/src/cli/mod.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/builder.rs 0.00% <0.00%> (ø)
crates/builder/src/task.rs 0.00% <0.00%> (ø)
crates/provider/src/alloy/mod.rs 85.96% <85.00%> (+85.96%) ⬆️
crates/builder/src/sender/mod.rs 0.96% <0.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

Flag Coverage Δ
unit-tests 59.50% <77.14%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 65.09% <0.00%> (-0.06%) ⬇️
dev ∅ <ø> (∅)
pool 66.20% <ø> (ø)
provider 26.22% <92.04%> (+5.96%) ⬆️
rpc 26.71% <ø> (ø)
sim 77.03% <ø> (ø)
tasks ∅ <ø> (∅)
types 69.66% <ø> (+2.05%) ⬆️
utils 30.06% <ø> (ø)

@dancoombs
Copy link
Collaborator

Have you been able to test this? Would love to simulate a timeout and watch the error propagate

@andysim3d
Copy link
Collaborator Author

Have you been able to test this? Would love to simulate a timeout and watch the error propagate

I did tried with anvil but it doesn't allow me inject latency. do you know other tools I can use to mock a long latency of json rpc?

@dancoombs
Copy link
Collaborator

Have you been able to test this? Would love to simulate a timeout and watch the error propagate

I did tried with anvil but it doesn't allow me inject latency. do you know other tools I can use to mock a long latency of json rpc?

Maybe write a unit test using https://crates.io/crates/tiny_http

bin/rundler/Cargo.toml Outdated Show resolved Hide resolved
@andysim3d andysim3d merged commit e6440e0 into main Dec 19, 2024
11 checks passed
@andysim3d andysim3d deleted the andy/time-out branch December 19, 2024 22:27
dancoombs pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants