Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Rundler): Handle standardized eth_sendRawTransactionConditional error codes #931

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

niveda-krish
Copy link
Contributor

[Closes/Fixes] # #925

Proposed Changes

  • Use error codes -32003 and -32005 when condition is not met on eth_sendRawTransactionConditional https://eips.ethereum.org/EIPS/eip-7796 (instead of string matching on json rpc error message)
  • Tests
image image

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 59.01%. Comparing base (6b9a2ad) to head (b661f61).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/builder/src/sender/mod.rs 0.00% 38 Missing ⚠️
crates/builder/src/sender/bloxroute.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/builder/src/sender/bloxroute.rs 0.00% <0.00%> (ø)
crates/builder/src/sender/mod.rs 1.01% <0.00%> (-0.31%) ⬇️
Flag Coverage Δ
unit-tests 59.01% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 64.56% <0.00%> (-0.28%) ⬇️
dev ∅ <ø> (∅)
pool 66.51% <ø> (ø)
provider 20.84% <ø> (ø)
rpc 25.87% <ø> (ø)
sim 76.76% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.81% <ø> (ø)
utils 31.73% <ø> (ø)

@0xfourzerofour
Copy link
Collaborator

Looks good just gotta update the PR title use a valid conventional commit message

@niveda-krish niveda-krish changed the title [builder] Handle standardized eth_sendRawTransactionConditional error codes feat(Rundler): Handle standardized eth_sendRawTransactionConditional error codes Dec 10, 2024
crates/builder/src/sender/mod.rs Outdated Show resolved Hide resolved
crates/builder/src/sender/mod.rs Show resolved Hide resolved
@niveda-krish niveda-krish merged commit e21dc0f into main Dec 11, 2024
10 checks passed
@niveda-krish niveda-krish deleted the niveda/conditional branch December 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants