prevent unnecessary .as_http_params() call

aleph-im · Oct 6, 2023 · 4927c47 · 4927c47
1 parent c452dad
commit 4927c47
Showing 1 changed file with 18 additions and 10 deletions.
diff --git a/src/aleph/sdk/client/client.py b/src/aleph/sdk/client/client.py
@@ -284,10 +284,14 @@ async def get_posts(
         )
 
         if not post_filter:
-            post_filter = PostFilter()
-        params = post_filter.as_http_params()
-        params["page"] = str(page)
-        params["pagination"] = str(page_size)
+            params = {
+                "page": str(page),
+                "pagination": str(page_size),
+            }
+        else:
+            params = post_filter.as_http_params()
+            params["page"] = str(page)
+            params["pagination"] = str(page_size)
 
         async with self.http_session.get("/api/v0/posts.json", params=params) as resp:
             resp.raise_for_status()
@@ -408,10 +412,15 @@ async def get_messages(
         )
 
         if not message_filter:
-            message_filter = MessageFilter()
-        params = message_filter.as_http_params()
-        params["page"] = str(page)
-        params["pagination"] = str(page_size)
+            params = {
+                "page": str(page),
+                "pagination": str(page_size),
+            }
+        else:
+            params = message_filter.as_http_params()
+            params["page"] = str(page)
+            params["pagination"] = str(page_size)
+
         async with self.http_session.get(
             "/api/v0/messages.json", params=params
         ) as resp:
@@ -479,8 +488,7 @@ async def watch_messages(
         self,
         message_filter: Optional[MessageFilter] = None,
     ) -> AsyncIterable[AlephMessage]:
-        if not message_filter:
-            message_filter = MessageFilter()
+        message_filter = message_filter or MessageFilter()
         params = message_filter.as_http_params()
 
         async with self.http_session.ws_connect(