Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new properties for Histogram and layout.Axis #432

Merged
merged 7 commits into from
May 13, 2024

Conversation

sven42
Copy link

@sven42 sven42 commented May 6, 2024

This fixes #431.

Furthermore:

  • Adds a demo for a basic histogram and a styled basic histogram using these new properties.
  • Adds the following methods to plotly.Plotly:
    • react()
    • relayout()
    • prune()
    • validate()
  • Updates dependencies, plugins and sbt

Best regards,
Sven

@sven42 sven42 force-pushed the task/add-properties branch from 591ed40 to 42ffa62 Compare May 6, 2024 15:56
@sbrunk
Copy link
Collaborator

sbrunk commented May 7, 2024

Looks good to me.

@alexarchambault are you ok with me merging this and cutting a v0.8.5 release afterwards? The release should work automated from CI after tagging with sbt-ci-release right? I haven't done it yet in this repo though so I want to check with you first.

@alexarchambault
Copy link
Owner

@sbrunk Sure, go ahead. Feel free to review / merge things as you feel in this repo.

@sbrunk sbrunk merged commit de05ca2 into alexarchambault:master May 13, 2024
3 checks passed
@sven42 sven42 deleted the task/add-properties branch May 13, 2024 09:06
@sbrunk
Copy link
Collaborator

sbrunk commented May 13, 2024

Uh, seems like there's some issue with publishing due to a missing pgp key: https://github.com/alexarchambault/plotly-scala/actions/runs/9061691273/job/24894080970
Perhaps you have to trigger the publishing job @alexarchambault?

@alexarchambault
Copy link
Owner

@sbrunk I just updated the secrets, that seems to have fixed it

@sbrunk
Copy link
Collaborator

sbrunk commented May 17, 2024

Thanks @alexarchambault!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some properties for Axis and Histogram
3 participants