Fix bug with dead items

alexferrari88 · Oct 23, 2022 · a27c448 · a27c448
1 parent 33228c1
commit a27c448
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/pkg/gohn/doc.go b/pkg/gohn/doc.go
@@ -98,5 +98,5 @@ Package GoHN is a wrapper for the Hacker News API: https://github.com/HackerNews
 package gohn
 
 const (
-	Version = "0.7.2"
+	Version = "0.7.3"
 )
diff --git a/pkg/gohn/items.go b/pkg/gohn/items.go
@@ -117,9 +117,11 @@ func (s *ItemsService) FetchAllDescendants(ctx context.Context, item *Item, fn I
 	}
 
 	// initialize kidsQueue so that the fetching in the for loop can start
-	for _, kid := range *item.Kids {
-		kidsQueue <- kid
-	}
+	go func() {
+		for _, kid := range *item.Kids {
+			kidsQueue <- kid
+		}
+	}()
 
 	// goroutine to close the done channel when all the items are fetched and processed
 	go func() {
@@ -159,6 +161,10 @@ L:
 						return
 					}
 				}
+				if it.Dead != nil && *it.Dead {
+					wg.Done()
+					return
+				}
 				commentsChan <- it
 			}()
 		// add the item to the map and, if it has any kid,