Removing unneeded and unused permissions (#11)

alexjyong · Nov 15, 2024 · 7f7d09a · 7f7d09a
1 parent cdd62e0
commit 7f7d09a
Show file tree

Hide file tree

Showing 31 changed files with 3,255 additions and 21 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -29,6 +29,7 @@ jobs:
             rm -rf platforms/android
             rm -rf plugins
             cordova platform add android --verbose &&
+            cordova plugin add cordova-custom-config &&
             cordova plugin add cordova-plugin-x-toast &&
             cordova plugin add cordova-plugin-screen-pinning --verbose &&
             cordova build android --release -- --keystore=/workspace/src/upload-keystore.jks --storePassword=$KEYSTORE_PASSWORD --alias=uploadkey --password=$ALIAS_PASSWORD --packageType=apk
@@ -74,6 +75,7 @@ jobs:
             rm -rf platforms/android
             rm -rf plugins
             cordova platform add android --verbose &&
+            cordova plugin add cordova-custom-config &&
             cordova plugin add cordova-plugin-x-toast &&
             cordova plugin add cordova-plugin-screen-pinning --verbose &&
             cordova build android --release -- --keystore=/workspace/src/upload-keystore.jks --storePassword=$KEYSTORE_PASSWORD --alias=uploadkey --password=$ALIAS_PASSWORD --packageType=bundle"

diff --git a/metadata/en-US/changelogs/00005.txt b/metadata/en-US/changelogs/00005.txt
@@ -0,0 +1,5 @@
+Version 0.0.5 release!
+
+ * Removed unneeded and unused internet permissions.
+
+If you find a bug, have a feature request, or have other concerns, please let me know on the issue tracker at https://github.com/alexjyong/BabbyPaint/issues.
diff --git a/metadata/en-US/images/phoneScreenshots/lockexample.png b/metadata/en-US/images/phoneScreenshots/lockexample.png
diff --git a/src/config.xml b/src/config.xml
@@ -1,19 +1,24 @@
 <?xml version='1.0' encoding='utf-8'?>
-<widget id="dev.alexjyong.babbypaint" version="0.0.4" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
+<widget id="dev.alexjyong.babbypaint" version="0.0.5" 
+    xmlns="http://www.w3.org/ns/widgets" 
+    xmlns:cdv="http://cordova.apache.org/ns/1.0"
+    xmlns:android="http://schemas.android.com/apk/res/android">
     <name>BabbyPaint</name>
     <description>Simple Paint app for kids</description>
     <author email="[email protected]" href="https://alexjyong.dev">
         Alex Yong
     </author>
     <content src="index.html" />
-    <allow-intent href="http://*/*" />
-    <allow-intent href="https://*/*" />
+
     <platform name="android">
-      <preference name="AndroidWindowSplashScreenAnimatedIcon" value="res/screen/android/play_store_512.png" />
-      <icon src="icon/android/res/mipmap-mdpi/icon.png" density="mdpi"/>
-      <icon src="icon/android/res/mipmap-hdpi/icon.png" density="hdpi"/>
-      <icon src="icon/android/res/mipmap-xhdpi/icon.png" density="xhdpi"/>
-      <icon src="icon/android/res/mipmap-xxhdpi/icon.png" density="xxhdpi"/>
-      <icon src="icon/android/res/mipmap-xxxhdpi/icon.png" density="xxxhdpi"/>
+        <!-- Remove INTERNET permission -->
+        <custom-preference name="android-manifest/uses-permission[@android:name='android.permission.INTERNET']" delete="true" />
+
+        <preference name="AndroidWindowSplashScreenAnimatedIcon" value="res/screen/android/play_store_512.png" />
+        <icon src="icon/android/res/mipmap-mdpi/icon.png" density="mdpi"/>
+        <icon src="icon/android/res/mipmap-hdpi/icon.png" density="hdpi"/>
+        <icon src="icon/android/res/mipmap-xhdpi/icon.png" density="xhdpi"/>
+        <icon src="icon/android/res/mipmap-xxhdpi/icon.png" density="xxhdpi"/>
+        <icon src="icon/android/res/mipmap-xxxhdpi/icon.png" density="xxxhdpi"/>
     </platform>
 </widget>