fix(subtree): "toggle or open" should open file, not view it #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `dirvish-subtree-toggle-or-open` utilizes `dirvish-subtree-toggle` to first attempt to toggle a directory line, then if that fails it assumes the current line represents a file and will attempt to open the file. Unfortunately, `dirvish-subtree-toggle` has an error handler, so if the directory toggle does fail it will view the file and not propagate the error. Since an error handler prevents the propagation of a directory toggle failure up to `dirvish-subtree-toggle-or-open`, the result is that when the current line represents a file, it will always be viewed instead of opened. Instead of depending on error propagation when the line is not a directory, this change instead checks to see if the line represents a directory first. When it is a directory, `dirvish-subtree-toggle` is called to handle the directory, otherwise the file is opened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
dirvish-subtree-toggle-or-openutilizesdirvish-subtree-toggleto first attempt to toggle a directory line, then if that fails it assumes the current line represents a file and will attempt to open the file. Unfortunately,dirvish-subtree-togglehas an error handler, so if the directory toggle does fail it will view the file and not propagate the error. Since an error handler prevents the propagation of a directory toggle failure up todirvish-subtree-toggle-or-open, the result is that when the current line represents a file, it will always be viewed instead of opened.Instead of depending on error propagation when the line is not a directory, this change instead checks to see if the line represents a directory first. When it is a directory,
dirvish-subtree-toggleis called to handle the directory, otherwise the file is opened.