Fix python3.8 failing testcases due to type hint (georgia-tech-db#1364)

alexxx-db · Nov 16, 2023 · 2575f4f · 2575f4f
1 parent 1fbb74f
commit 2575f4f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/evadb/catalog/catalog_manager.py b/evadb/catalog/catalog_manager.py
@@ -333,7 +333,7 @@ def insert_job_history_catalog_entry(
 
         return job_history_entry
 
-    def get_job_history_by_job_id(self, job_id: int) -> list[JobHistoryCatalogEntry]:
+    def get_job_history_by_job_id(self, job_id: int) -> List[JobHistoryCatalogEntry]:
         """Returns all the entries present for this job_id on in the history.
 
         Args:
@@ -343,7 +343,7 @@ def get_job_history_by_job_id(self, job_id: int) -> list[JobHistoryCatalogEntry]
 
     def update_job_history_end_time(
         self, job_id: int, execution_start_time: datetime, execution_end_time: datetime
-    ) -> list[JobHistoryCatalogEntry]:
+    ) -> List[JobHistoryCatalogEntry]:
         """Updates the execution_end_time for this job history matching job_id and execution_start_time.
 
         Args:

diff --git a/evadb/catalog/services/job_history_catalog_service.py b/evadb/catalog/services/job_history_catalog_service.py
@@ -14,6 +14,7 @@
 # limitations under the License.
 
 import datetime
+from typing import List
 
 from sqlalchemy import and_
 from sqlalchemy.orm import Session
@@ -54,7 +55,7 @@ def insert_entry(
 
         return job_history_catalog_obj.as_dataclass()
 
-    def get_entry_by_job_id(self, job_id: int) -> list[JobHistoryCatalogEntry]:
+    def get_entry_by_job_id(self, job_id: int) -> List[JobHistoryCatalogEntry]:
         """
         Get all the job history catalog entry with given job id.
         Arguments: