- ignore shared collections, these are deliberate and there will be n…

…o changes within them (same as Alfa change in 5.4.19)

- don't set the type as a side-effect of getType() method on SimpleValue (mimics behaviour of 5.4)

hibernate-core/src/main/java/org/hibernate/engine/internal/Collections.java

@@ -23,7 +23,6 @@
 import org.hibernate.persister.collection.CollectionPersister;
 import org.hibernate.pretty.MessageHelper;
 import org.hibernate.type.CollectionType;
-
 import org.jboss.logging.Logger;
 
 /**
@@ -184,9 +183,12 @@ public static void processReachableCollection(
 		// who set up circular or shared references between/to collections.
 		if ( ce.isReached() ) {
 			// We've been here before
-			throw new HibernateException(
-					"Found shared references to a collection: " + type.getRole()
-			);
+
+			// Alfa change - ignore shared collections, these are deliberate and there will be no changes within them.
+			return;
+//			throw new HibernateException(
+//					"Found shared references to a collection: " + type.getRole()
+//			);
 		}
 
 		ce.setReached( true );

hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java

@@ -14,8 +14,9 @@
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
-import java.util.Properties;
 import java.util.Objects;
+import java.util.Properties;
+
 import javax.persistence.AttributeConverter;
 
 import org.hibernate.FetchMode;
@@ -515,7 +516,7 @@ public Type getType() throws MappingException {
 			throw new MappingException( msg );
 		}
 
-		return type = result;
+		return result;
 	}
 
 	@Override