Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version checking for nmod_poly_mat_shift, introduced in flint 3.0 #151

Merged
merged 2 commits into from
Jul 8, 2024
Merged

add version checking for nmod_poly_mat_shift, introduced in flint 3.0 #151

merged 2 commits into from
Jul 8, 2024

Conversation

vneiger
Copy link
Contributor

@vneiger vneiger commented Jul 5, 2024

This was preventing compilation with -all-static due to multiple definition of poly_mat_shift.

@vneiger vneiger requested a review from jerebertho July 5, 2024 15:51
@vneiger
Copy link
Contributor Author

vneiger commented Jul 5, 2024

CI will not detect anything about this, just like it did not see the existing problem with -all-static compilation. So I suggest to wait for merging at least until @jerebertho can check that it solves the issue on his side as well (we were discussing it together this afternoon).

@jerebertho
Copy link
Contributor

This indeed solves the issue on my side.

jerebertho
jerebertho approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jerebertho jerebertho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@jerebertho jerebertho merged commit 940ec8a into algebraic-solving:master Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerebertho jerebertho jerebertho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vneiger @jerebertho