Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index): remove getWidgetState #6476

Merged
merged 3 commits into from
Dec 18, 2024
Merged

feat(index): remove getWidgetState #6476

merged 3 commits into from
Dec 18, 2024

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Dec 17, 2024

The old method has long been deprecated and has no usage inside instantsearch outside of running a warning.

FX-3197

BREAKING CHANGE: rename getWidgetState to getWidgetUiState in your custom widgets or connectors.

The old method has long been deprecated and has no usage inside instantsearch outside of running a warning.

The warning on adding a widget with getWidgetState is still present, but slightly reworded.

[FX-3197]

BREAKING CHANGE: rename getWidgetState to getWidgetUiState in your custom widgets or connectors.
@Haroenv Haroenv added this to the instantsearch.js v5 milestone Dec 17, 2024
Copy link

codesandbox-ci bot commented Dec 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2b18ce4:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@Haroenv Haroenv requested review from dhayab and sarahdayan December 17, 2024 13:57
@Haroenv Haroenv merged commit 1778a8a into next Dec 18, 2024
10 checks passed
@Haroenv Haroenv deleted the fix/remove-gws branch December 18, 2024 13:14
Haroenv added a commit that referenced this pull request Dec 26, 2024
The old method has long been deprecated and has no usage inside instantsearch outside of running a warning.

The warning on adding a widget with getWidgetState is still present, but slightly reworded.

[FX-3197]

BREAKING CHANGE: rename getWidgetState to getWidgetUiState in your custom widgets or connectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants