eval: split TestTransactionGroup from BlockEvaluator using TransactionGroupTester #5818
+109
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing TestEvalContext
cce
force-pushed
the
parallelizable-test-txn
branch
from
506b9ed to
b09a797
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5818 +/- ##
==========================================
- Coverage 51.88% 51.14% -0.75%
==========================================
Files 639 639
Lines 85489 85511 +22
==========================================
- Hits 44359 43736 -623
- Misses 38320 38909 +589
- Partials 2810 2866 +56 ☔ View full report in Codecov by Sentry. |
gmalouf
previously approved these changes
Oct 17, 2024
jannotti
reviewed
Oct 23, 2024
cce
changed the title
jannotti
approved these changes
Nov 20, 2024
gmalouf
approved these changes
Nov 27, 2024
algorandskiy
approved these changes
Dec 12, 2024
| @@ -904,10 +904,34 @@ func (eval *BlockEvaluator) ResetTxnBytes() { | |||
| eval.blockTxBytes = 0 | |||
| } | |||
|
|
|||
| // TestTransactionGroup is only called by tests. | |||
| func (eval *BlockEvaluator) TestTransactionGroup(txgroup []transactions.SignedTxn) error { | |||
There was a problem hiding this comment.
then move it to eval_test.go?
| @@ -1163,6 +1188,7 @@ func (eval *BlockEvaluator) transaction(txn transactions.SignedTxn, evalParams * | |||
| } | |||
|
|
|||
| // Transaction already in the ledger? | |||
| // this checks against the txns added to this evaluator; testTransaction currently only checks against committed txns. | |||
There was a problem hiding this comment.
// this checks against the txns added to this evaluator; testTransaction currently only checks against committed txns.
This is not 100% accurate, checkDup checks the ledger as well, maybe reword to "against the txns added to this evaluator and the ledger" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
eval.TestTransactionGroup (and TestTransaction) need only read-only access to a few details about the next pending block. This introduces an interface TestEvalContext that is used by the transaction pool, so that there can be parallel TX backlog workers checking if transactions are well-formed and move them from the backlogQueue to the postVerificationQueue.
Test Plan
Updated TxHandler test that was checking Remember() vs Test() and counting metrics bumped by different kinds of err returns.