fix: no timeout for urlopen issue #526

algorand · Jan 20, 2024 · 1e38af4 · 1e38af4
1 parent 3e64019
commit 1e38af4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/algosdk/kmd.py b/algosdk/kmd.py
@@ -26,7 +26,7 @@ def __init__(self, kmd_token, kmd_address):
         self.kmd_token = kmd_token
         self.kmd_address = kmd_address
 
-    def kmd_request(self, method, requrl, params=None, data=None):
+    def kmd_request(self, method, requrl, params=None, data=None, timeout=30):
         """
         Execute a given request.
 
@@ -35,6 +35,7 @@ def kmd_request(self, method, requrl, params=None, data=None):
             requrl (str): url for the request
             params (dict, optional): parameters for the request
             data (dict, optional): data in the body of the request
+            timeout (int, optional): request timeout in seconds
 
         Returns:
             dict: loaded from json response body
@@ -56,7 +57,7 @@ def kmd_request(self, method, requrl, params=None, data=None):
         )
         resp = None
         try:
-            resp = urlopen(req)
+            resp = urlopen(req, timeout=timeout)
         except urllib.error.HTTPError as e:
             e = e.read().decode("utf-8")
             try:

diff --git a/algosdk/v2client/algod.py b/algosdk/v2client/algod.py
@@ -61,6 +61,7 @@ def algod_request(
         data: Optional[bytes] = None,
         headers: Optional[Dict[str, str]] = None,
         response_format: Optional[str] = "json",
+        timeout: Optional[int] = 30,
     ) -> AlgodResponseType:
         """
         Execute a given request.
@@ -72,6 +73,7 @@ def algod_request(
             data (bytes, optional): data in the body of the request
             headers (dict, optional): additional header for request
             response_format (str, optional): format of the response
+            timeout (int, optional): request timeout in seconds
 
         Returns:
             dict loaded from json response body when response_format == "json"
@@ -101,7 +103,7 @@ def algod_request(
         )
 
         try:
-            resp = urlopen(req)
+            resp = urlopen(req, timeout=timeout)
         except urllib.error.HTTPError as e:
             code = e.code
             es = e.read().decode("utf-8")

diff --git a/algosdk/v2client/indexer.py b/algosdk/v2client/indexer.py
@@ -31,7 +31,7 @@ def __init__(self, indexer_token, indexer_address, headers=None):
         self.headers = headers
 
     def indexer_request(
-        self, method, requrl, params=None, data=None, headers=None
+        self, method, requrl, params=None, data=None, headers=None, timeout=30
     ):
         """
         Execute a given request.
@@ -42,6 +42,7 @@ def indexer_request(
             params (dict, optional): parameters for the request
             data (dict, optional): data in the body of the request
             headers (dict, optional): additional header for request
+            timeout (int, optional): request timeout in seconds
 
         Returns:
             dict: loaded from json response body
@@ -70,7 +71,7 @@ def indexer_request(
         )
 
         try:
-            resp = urlopen(req)
+            resp = urlopen(req, timeout=timeout)
         except urllib.error.HTTPError as e:
             e = e.read().decode("utf-8")
             try: