FOR REVIEW ONLY: py-algorand-sdk v2.6.0 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Allow the various key-ish fields of a keyreg txn to be bytes Previously, these fields were required to be base64 encoded, which seems like a strange requirement. Now they may be bytes or b64 strings. Either way, they are stored in the python object as b64 strings to maintain compatibility with our original decision, regardless of how strange it was. Added a few doc string cleanups.
* Uses sp.min_fee if available Rather than use a hard coded constant for min_fee, use the one that is returned in SuggestedParams if available. Since some people may create a SuggestedParams by hand rather than get one from server (because our APIs require one even though the caller may feel they "know better"), continue to use the constant if the sp.min_fee is None. * Only use the constant if sp.min_fee is None (not when 0)
onetechnical
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Bugfixes
WrongAmountTypeerror by @algolog in fix: Fix initialization forWrongAmountTypeerror #532Enhancements
Other
New Contributors
WrongAmountTypeerror #532Full Changelog: v2.5.0...v2.6.0